Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): # symbol in deps id stripped by browser #12415

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Mar 14, 2023

Description

If an optimized deps id contains # symbol, it will be stripped as a URL request from the browser, which will make the asset unreachable.

For example

<script type='module'>
import contains from 'es5-ext/string/#/contains'
</script>

There will be a file named es5-ext_string_#_contains.js in .vite/deps after pre-bundle. And this file will be visited as http://localhost:5173/node_modules/.vite/deps/es5-ext_string_#_contains.js?v=ebf1e6a3 in the browser. Then the # symbol and characters behind it will be stripped by the browser.

Additional context


This PR replaced # with [sharp], which may confuse the user. But I can't figure out a better replacement :(

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sun0day sun0day changed the title fix(optimizer): # symbol of deps id stripped in url fix(optimizer): # symbol in deps id stripped by browser Mar 14, 2023
@patak-dev patak-dev added p3-minor-bug An edge case that only affects very specific usage (priority) feat: deps optimizer Esbuild Dependencies Optimization labels Mar 14, 2023
@bluwy bluwy merged commit e23f690 into vitejs:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: deps optimizer Esbuild Dependencies Optimization p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants